Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC1918 is not the USA #8796

Open
udf2457 opened this issue Sep 15, 2015 · 4 comments
Open

RFC1918 is not the USA #8796

udf2457 opened this issue Sep 15, 2015 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Backlog (Help wan...

Comments

@udf2457
Copy link

udf2457 commented Sep 15, 2015

Hey guys,

Reserved IANA space such as RFC1918 is NOT the United States.

Piwik should recognise visitors from reserved addresses and assign a neutral country identifier that doesn't mess up the statistics un-necessarily.

Whilst you're at it, please also see here (http://www.iana.org/numbers) for lists of other ranges that are not the United States.

Thank you !
@sgiehl
Copy link
Member

sgiehl commented Sep 15, 2015

Which geolocation provider are you using?
The default one is very inaccurate.

@udf2457
Copy link
Author

udf2457 commented Sep 15, 2015

The default one.

But there is a difference between "inaccurate" and "missing the completely obvious" ....

Its not exactly like we're talking about some subtle regional IP address differences, covering RFC1918 and other reserved ranges is not rocket science.

@sgiehl
Copy link
Member

sgiehl commented Sep 15, 2015

The default one doesn't look at any IP at all. It just tries to guess the country using the language the user's browser sends. So anyone sending en-US will be located in the US.

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 20, 2015
@mattab mattab added this to the Mid term milestone Sep 20, 2015
@mattab
Copy link
Member

mattab commented Sep 20, 2015

It would make sense to make our default provider smarter by using a small set of static IP addresses. We will not work on this as it's low priority for us, but for sure a pull request will be welcome!

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@mattab @sgiehl @udf2457