New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all utf8 4-byte characters in tracked urls with � #8765
Conversation
IMHO, this is "nice hack" - if one can write this. Feedback:
|
@sgiehl I've added a system tests, once build is green will merge it 👍 |
Replace all utf8 4-byte characters in tracked urls with �
👍 |
Hi, We have updated to Piwik 3.0.2 and PHP 7.0.16 and getting following error: Error in Piwik (tracker): Error query: SQLSTATE[HY000]: General error: 1366 Incorrect string value: '\xD0_\xD0\xBB\xD0\xB5...' for column 'name' at row 1 In query: INSERT INTO piwik_log_action (name, hash, type, url_prefix) VALUES (?,CRC32(?),?,?) Parameters: array ( 0 => '/products/Счетчики Ð_лектроÑ_нергии/?cid=91701', 1 => '/products/Счетчики Ð_лектроÑ_нергии/?cid=91701', 2 => 1, 3 => 0, ) Other characters are been shown fine in dashboard but this error is appearing in PHP error log ? |
Still having this issue with 3.4.0 on PHP 7.2 [09-May-2018 14:11:33 UTC] Error in Matomo: Your Matomo version 3.4.0 is up to date. |
Ok, i get that the collation/schema needs to change to SUPPORT mb4. But I thought the solution was to modify the text as to avoid the need for mb4 in the first place? That the emoji would be replaced with the � character? Which would mean it's not doing it's job properly. Is that incorrect? Looking at the error message closer, i do see the � in there, maybe it's not properly replacing the entirety of the emoji? |
Here is the site in question that was causing the issue: http://www.phoenixrealestateandhomes.com/selling/alternatives-to-opendoor-flip-my-house/#/flipping-houses-keep-your-nest-egg |
@gmariani as it is not supposed to trigger an error, could you please paste in a new issue (this one is already closed), the |
As described in #7766 all 4-byte characters in urls currently fail to be tracked.
As long as we won't switch the table layouts to utf8mb4 this "hack" makes it possible to track those urls, even if they are wrong afterwards, as some characters might get replaced.