New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visitor Log: Getting "Segment not applied" notification although segment is applied. #7892
Comments
Good find.
|
I have actually no idea how to fix this, at least at this point of time. It might be easier after Piwik 3.0.0 and after #7822 is resolved. The SegmentEditor is loaded in To solve this we'd maybe need to define for each report whether it depends on "real time logs" or "archived reports". Then, when loading a page, we'd need to check whether there is at least one report that uses "archives" and whether the config for segment is actually disabled. Eg there could be a dashboard showing only "real time log" reports, then we would not be allowed to show it. As the dialog is shown only on the initial page load, we would not be allowed to show the dialog if there are only "real time reports" shown, but as soon as one changes the page to another report (it is not a complete page reload, it is loaded via XHR), we'd need to show the dialog if there's an "archived report" shown. All this is a lot of work and probably requires a lot of refactorings. I'd rather postpone it to somewhen far after Piwik 3.0.0. Having to define whether it is a "real time report" or "archive report" is rather annoying and maybe not really doable by a 3rd party developer so our framework would ideally detect this automatically after #7470 is done |
@mattab are you eg to move it to mid term? |
@tsteur thanks for analysis. Since it's not do-able in reasonable time, and it is not critical in terms of user impact, moving to |
@tsteur I suppose this can be closed and no longer an issue? |
sure |
See screenshot.
I'm getting this notification although the segment is actually applied to the visitor log. So 2 possibilities:
Some of my config entries include
The text was updated successfully, but these errors were encountered: