Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor Log: Getting "Segment not applied" notification although segment is applied. #7892

Closed
tsteur opened this issue May 12, 2015 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@tsteur
Copy link
Member

tsteur commented May 12, 2015

See screenshot.

I'm getting this notification although the segment is actually applied to the visitor log. So 2 possibilities:

  • The segment should not have been applied and the notification is correct
  • The segment is applied correctly and the notification should not be shown

segment_not_applied

Some of my config entries include

[General]
browser_archiving_disabled_enforce = 1
enable_browser_archiving_triggering = 0
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 12, 2015
@mattab
Copy link
Member

mattab commented May 15, 2015

Good find.

  • The popover should be displayed only when requesting archived reports.
  • Because the segment works well for Visitor Log, Visitor Profile, real time map, it should not display the popover message.

@mattab mattab added this to the 2.14.0 milestone May 15, 2015
@tsteur
Copy link
Member Author

tsteur commented Jun 7, 2015

I have actually no idea how to fix this, at least at this point of time. It might be easier after Piwik 3.0.0 and after #7822 is resolved.

The SegmentEditor is loaded in CoreHome.index before any report is loaded. In the initial page load an HTML attribute /JS property isSegmentNotAppliedBecauseBrowserArchivingIsDisabled is set that triggers the modal confirm notification. The actual report is loaded later in another XHR and the SegmentSelector does actually not know anything about the report that is loaded later.

To solve this we'd maybe need to define for each report whether it depends on "real time logs" or "archived reports". Then, when loading a page, we'd need to check whether there is at least one report that uses "archives" and whether the config for segment is actually disabled. Eg there could be a dashboard showing only "real time log" reports, then we would not be allowed to show it.

As the dialog is shown only on the initial page load, we would not be allowed to show the dialog if there are only "real time reports" shown, but as soon as one changes the page to another report (it is not a complete page reload, it is loaded via XHR), we'd need to show the dialog if there's an "archived report" shown.

All this is a lot of work and probably requires a lot of refactorings. I'd rather postpone it to somewhen far after Piwik 3.0.0. Having to define whether it is a "real time report" or "archive report" is rather annoying and maybe not really doable by a 3rd party developer so our framework would ideally detect this automatically after #7470 is done

@tsteur
Copy link
Member Author

tsteur commented Jun 7, 2015

@mattab are you eg to move it to mid term?

@mattab
Copy link
Member

mattab commented Jun 7, 2015

@tsteur thanks for analysis. Since it's not do-able in reasonable time, and it is not critical in terms of user impact, moving to Mid term

@mattab mattab modified the milestones: Mid term, 2.14.0 Jun 7, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab
Copy link
Member

mattab commented Sep 25, 2018

@tsteur I suppose this can be closed and no longer an issue?

@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2018

sure

@tsteur tsteur closed this as completed Sep 25, 2018
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants