Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to rename metrics based on the type of the site #7824

Open
tsteur opened this issue May 4, 2015 · 3 comments
Open

Add possibility to rename metrics based on the type of the site #7824

tsteur opened this issue May 4, 2015 · 3 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@tsteur
Copy link
Member

tsteur commented May 4, 2015

Needed for #7131 and #4734.

A "type" could be a plugin that defines a type "Website" or "MobileApp". For example while a type "Website" may use the wording "Visits and Visitors" another type "MobileApp" may want to use the wording "Users and Sessions".

Problems / Requirements

Possible solutions

  • We might need to refactor the Metrics class https://github.com/piwik/piwik/blob/2.13.0-rc2/core/Metrics.php#L26 into many tiny classes and only access them via those classes. Metrics is marked as @api so BC might be an issue.
  • We could do it in getProcessedReport/getReportMetadata but it would almost require that we render reports in the browser via JavaScript.

To be considered

Out of scope

  • The metric itself would stay the same in the beginning for simplicity, eg nb_visits would not become nb_sessions.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels May 4, 2015
@mattab
Copy link
Member

mattab commented Jul 15, 2015

@tsteur moving into Mid term - if you think this is more important or will be done earlier, let me know

@mattab mattab added this to the Mid term milestone Jul 15, 2015
@tsteur
Copy link
Member Author

tsteur commented Jul 15, 2015

If we have generic wording then it's okay to delay. We will just have generic wording for websites as well (which is okay if I remember correct)

@mattab
Copy link
Member

mattab commented Jul 22, 2015

Using Generic wording #7826 has been moved to 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants