You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mnapoli opened this issue
Apr 10, 2015
· 2 comments
Labels
RFCIndicates the issue is a request for comments where the author is looking for feedback.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Manager alone is confusing (the name doesn't mean anything) and can lead to conflicts. This is already a problem (we end up e.g. aliasing the class name in a lot of places) but I think it's a good time to take the opportunity to rename it as the problem will only get more visible when using dependency injection.
It could be renamed to Piwik\Plugin\PluginManager for example.
Of course backward compatibility would be kept and Piwik\Plugin\Manager still exist as an alias to the new class
Thoughts?
The text was updated successfully, but these errors were encountered:
mnapoli
added
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
RFC
Indicates the issue is a request for comments where the author is looking for feedback.
labels
Apr 10, 2015
After thinking about it I think it's best to do that for 3.0 as there will be less risks of conflicts with the DI refactorings and we probably won't have the same level of BC to keep.
RFCIndicates the issue is a request for comments where the author is looking for feedback.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Following #7644 the plugin manager will be stored in the DI container, which means we will be able to inject it by simply type-hinting it:
Manager
alone is confusing (the name doesn't mean anything) and can lead to conflicts. This is already a problem (we end up e.g. aliasing the class name in a lot of places) but I think it's a good time to take the opportunity to rename it as the problem will only get more visible when using dependency injection.It could be renamed to
Piwik\Plugin\PluginManager
for example.Of course backward compatibility would be kept and
Piwik\Plugin\Manager
still exist as an alias to the new classThoughts?
The text was updated successfully, but these errors were encountered: