Allow setting empty userId, refs #7402 #7518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added a commit
that referenced
this pull request
Mar 26, 2015
|
Hi @Sija I'm not 100% sure yet about this change, because some users call the setUserId('') on each pageview. This may break tracking accuracy for these guys (not sure). Maybe we could make the change only when setUserId(false) is called (with (I've added some unit tests as we'd need to add some tests with the PR in case you want to contribute some!) |
mattab
added
the
Pull Request WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can clear
userIdby callingsetUserIdwith falsy value, likenull,undefinedor empty string''.#7402