Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixing " and ' in tracker code #6869

Open
ThaDafinser opened this issue Dec 17, 2014 · 2 comments
Open

Mixing " and ' in tracker code #6869

ThaDafinser opened this issue Dec 17, 2014 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@ThaDafinser
Copy link
Contributor

https://github.com/piwik/piwik/blob/master/core/Tracker/TrackerCodeGenerator.php#L81-L91

If you enable advanced options, then " will be used.

The default block is in ' (also my favorite 馃憤 )
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 17, 2014
@mattab mattab added this to the Mid term milestone Dec 17, 2014
@mattab
Copy link
Member

mattab commented Dec 17, 2014

Hi @ThaDafinser feel free to issue pull request if you care about this 馃憤

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@sgiehl
Copy link
Member

sgiehl commented Nov 22, 2017

Small note: Using ' everywhere won't be possible. We use a json_encode to encode the values set by user (e.g. custom variables). json_encode always uses " to escape strings, which we can't avoid. So the only thing we could do would be to change all other values, or to change everything consistent to "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@mattab @ThaDafinser @sgiehl