Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable static PNG image graphs during Continuous Integration #6864

Open
1 of 5 tasks
mattab opened this issue Dec 16, 2014 · 1 comment
Open
1 of 5 tasks

Enable static PNG image graphs during Continuous Integration #6864

mattab opened this issue Dec 16, 2014 · 1 comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Dec 16, 2014

The goal of this issue is to make our Continuous Integration run automated tests for the static PNG graphs generated by the ImageGraph module.

in 2.10.0-b8 we got hit by a couple regressions in the static Image Graphs see #6863 #6862 - we should be able to detect such huge regressions and prevent them occuring again without us noticing!

Current state

We actually had to remove PNG graphs from the CI because there were minor pixel differences in images between local machine and CI, causing tests to fail.

  1. on system tests builds we see the tests are marked as skipped: 1) Piwik\Tests\System\EcommerceOrderWithItemsTest::testImagesIncludedInTests - Scheduled reports generated during integration tests will not contain the image graphs. For tests to generate images, use a machine with the following specifications : OS = linux, PHP = 5.5 and GD = 2.1.1.
  2. on UI screenshot tests the sparklines are removed here with \Piwik\Visualization\Sparkline::$enableSparklineImages = false;

Proposed steps

  • how to make travis run the same GD version as all/most core developers?
  • create a new integration test in ImageGraph plugin that will generate the evolution graph, pie chart, bar graph, with static data from a test API. this will help us isolate the feature and depend less on our system tests. Example typical graphs are listed in the doc.
  • enable sparklines in UI tests and check the UI build is green on both local machine and remote (that same sparklines are generated)
  • enable scheduled reports that include graphs
  • celebrate!!
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Dec 16, 2014
@mattab mattab added this to the Short term milestone Dec 16, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Apr 7, 2015
@mattab mattab modified the milestones: Short term, Mid term Apr 7, 2015
@mattab mattab removed c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Sep 23, 2015
@mattab
Copy link
Member Author

mattab commented Sep 23, 2015

The Graphs generated by the ImageGraph.get API (dev doc) is now tested by automated tests. This was added in https://github.com/piwik/piwik-ui-tests/commit/b21a91666f6b86cbb317ad7566dc2f30345cbdd7

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant