Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range subperiods have timezones set only for relative dates #6492

Open
d-skora opened this issue Oct 21, 2014 · 1 comment
Open

Range subperiods have timezones set only for relative dates #6492

d-skora opened this issue Oct 21, 2014 · 1 comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@d-skora
Copy link

d-skora commented Oct 21, 2014

There seems to be an issue in https://github.com/piwik/piwik/blob/2.8.1/core/Period/Range.php#L203

After discussions with @mgazdzik about #320 and the problem of testing if the fix is working correctly I were investigating why subperiods don't have a correct timestamp/timezone for a given range of time.

I found out that at this line https://github.com/piwik/piwik/blob/2.8.1/core/Period/Range.php#L203 we're ignoring setting a timestamp for dates that aren't relative.

@mgazdzik asked me to set up this issue as a start of discussion why we don't want to adjust timestamps for those dates.
@mattab
Copy link
Member

mattab commented Oct 21, 2014

@d-skora thanks for report. Maybe you can manage to add a unit test that fails showcasing the bug? so far we cannot reproduce an issue

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 21, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Nov 3, 2014
@mattab mattab added this to the Short term milestone Nov 3, 2014
@mattab mattab modified the milestones: Long term, Short term Apr 9, 2015
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. and removed Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Apr 9, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @d-skora