Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when angularjs 1.3 is available and used in piwik, make sure bindtoController is used for all directives w/ controllers #6365

Closed
diosmosis opened this issue Oct 2, 2014 · 2 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@diosmosis
Copy link
Member

As title. Currently, scope variables are not included in the controller scope when controllerAs is used (so a directive's scope variables are not bound to the object created by controllerAs).

This is fixed in angularjs 1.3 w/ the bindtoController attribute (see https://github.com/jesselpalmer/angular.js/commit/b8be80d578fac7839b0a387906921560ee36e419 ).

@mattab mattab added this to the Mid term milestone Oct 2, 2014
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 2, 2014
@mattab mattab modified the milestones: 3.0.0, Long term Jul 8, 2016
@sgiehl
Copy link
Member

sgiehl commented Nov 21, 2017

@diosmosis we are using angular 1.6 now. is this issue still relevant and maybe something we should handle soon?

@diosmosis
Copy link
Member Author

It’s not important. I’ll close it.

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants