Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a User Id is set, try to attach User ID to existing visit before user logged in #6313

Closed
mgazdzik opened this issue Sep 26, 2014 · 6 comments
Closed

When a User Id is set, try to attach User ID to existing visit before user logged in #6313

mgazdzik opened this issue Sep 26, 2014 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.8.0

Comments

@mgazdzik
Copy link
Contributor

It would be nice to have possibility of recognizing when one session is actually continous, regardless visitor_id has changed.
Example use case:

  • user surfs website in logged out state
  • user logs in, continues surfing (page passes user_id to tracking code)
  • use logs out and continues to surf (but without user_id this time)

Piwik should recognize that even if visitor_id has changed/disappeared, this is actually the same visit.
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 1, 2014
@mattab
Copy link
Member

mattab commented Oct 1, 2014

Thanks for suggestion, it makes sense.

  • Current logic: Match pageview to a visit with the same User_ID idvisitor
  • Desired logic: Match pageview to a visit with (the same User_ID idvisitor) OR (the same fingerprinting config_id AND no User_ID idvisitor)

Note: in your example there would be two visits:

  • first visit for logged-out visitor that then logs in (the logged-out pageviews end up in the visit with User_ID)
  • second visit for visitor after he logged-out (visitor without User_ID)

@mattab mattab changed the title [Feature request] Tie user id to previous sessions When a User Id is set, try to attach User ID to existing visit before user logged in Oct 1, 2014
mattab added a commit that referenced this issue Oct 1, 2014
@mattab
Refs #6313 Adding test case showing the bug (it creates a new visit b…
be25924 
…ut we want this visit to be re-used)
mattab added a commit that referenced this issue Oct 1, 2014
@mattab
Fix one test refs #6313
2cd5f09
@mattab mattab added this to the Piwik 2.8.0 milestone Oct 1, 2014
@mattab mattab closed this as completed in cd1b52d Oct 1, 2014
@schmidt
Copy link

schmidt commented Nov 21, 2014

This is a great addition. Maybe the documentation should be updated accordingly.

@mattab
Copy link
Member

mattab commented Nov 22, 2014

@schmidt thanks for the note! I've updated the section Signing-in use case which was outdated.

@schmidt
Copy link

schmidt commented Nov 23, 2014

Great. Thanks for the super quick fix.

@nemnesic
Copy link

is this part of the core now? If yes, what version?

@mattab
Copy link
Member

mattab commented Dec 28, 2014

latest 2.9.1 or latest RC http://piwik.org/faq/how-to-update/faq_159/

@tsteur tsteur mentioned this issue Jan 22, 2015
Closed
@mattab mattab mentioned this issue Apr 8, 2015
Closed
@mattab mattab mentioned this issue Apr 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
4 participants
@schmidt @mattab @nemnesic @mgazdzik