Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AngularJS: Use elements instead of attributes if a directive is a control #6283

Closed
tsteur opened this issue Sep 24, 2014 · 1 comment
Closed

AngularJS: Use elements instead of attributes if a directive is a control #6283

tsteur opened this issue Sep 24, 2014 · 1 comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@tsteur
Copy link
Member

tsteur commented Sep 24, 2014

See https://github.com/johnpapa/angularjs-styleguide#directives

Why?: It makes sense.

Why?: While we can allow the directive to be used as a class, if the directive is truly acting as an element it makes more sense as an element or at least as an attribute.

<!-- avoid -->
<div class="my-calendar-range"></div>

<!-- recommended -->
<my-calendar-range></my-calendar-range>

Need to check what it takes to make it work in all major browsers (maybe including IE8)
@tsteur tsteur added this to the Piwik 2.8.0 milestone Sep 24, 2014
This was referenced Sep 24, 2014
Closed
Closed
@tsteur tsteur modified the milestones: Mid term, Piwik 2.8.0 Sep 25, 2014
@tsteur tsteur mentioned this issue Sep 25, 2014
Open
@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2014

Moved to mid-term as we will wait re IE8

@tsteur tsteur mentioned this issue Sep 25, 2014
Open
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 26, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab