Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in login string length #522

Closed
mattab opened this issue Jan 25, 2009 · 3 comments
Closed

inconsistency in login string length #522

mattab opened this issue Jan 25, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 25, 2009

Table "piwik_user_dashboard" has got a login-attribute, which is limited to 20 chars.
I’ve set up an username with more than 20 chars and therefore the login-value was cut to 20 chars and I couldn’t change any settings in the dashboard. I went to phpMyAdmin and changed the login-attribute to 60 chars.

Piwik should throw an error if someone tries to setup an user with more than 20 chars or you should raise the char-length in the database.

Solution: we should make sure that login is restricted to the same length in the mysql tables (60 chars), and that it’s properly checked against when creating a new user.

@mattab
Copy link
Member Author

mattab commented Mar 2, 2009

fixed in 941 all login fields are now consistently restricted to maximum 100 characters string length + bundling DB updates

@robocoder
Copy link
Contributor

The change wasn't applied to core/Piwik.php, so fresh installs after 0.2.32 still create 20 character login fields.

@robocoder
Copy link
Contributor

(In [1349]) fixes #522 - inconsistency in login string length

(update script to be addressed in #894)

@mattab mattab added this to the Piwik 0.4.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants