Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System check update message regarding config file permissions #4046

Closed
oerdnj opened this issue Jul 11, 2013 · 7 comments
Closed

System check update message regarding config file permissions #4046

oerdnj opened this issue Jul 11, 2013 · 7 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@oerdnj
Copy link

oerdnj commented Jul 11, 2013

This is related to #1590, the System Check page still recommends:

To fix this error on your Linux system, try typing in the following command(s):
chmod a+w /var/www/piwik/config

and it marks the issue as "critical":

Uh-oh! Piwik has detected some critical issues with your Piwik setup. These issues should be fixed immediately. See below for more information.

Such advice is just the first step to getting hacked.

@mattab
Copy link
Member

mattab commented Jul 16, 2013

Thanks for pointing it out. The System check screen is quite new and this is one of the first bugs on it in months.

What is your exact setup (command chmod you run on config folder?)

What do you recommend we suggest instead? move from "critical" level to "Notice" be enough for fix?

@mattab
Copy link
Member

mattab commented Jul 17, 2013

In 80dd44b: Fixes #4046 Not checking for config/config.ini.php in the system check since it's not required (and we display warning on other screens that need config writable)
Also fixing install process regression and removing config.ini.sample.php

@oerdnj
Copy link
Author

oerdnj commented Jul 17, 2013

I was just going to check that you should remove this check since you don't need config/ directory writeable most of the time, and I see you have already done that.

Thanks!

@oerdnj
Copy link
Author

oerdnj commented Jul 17, 2013

Anyway as a side note - never ever recommend chmod 777 since this gives the access to all users on the system, which is really bad on shared hosts.

I would ever say that if you want to have a secure setup then you should secure all directories (write protect) with files which might get executed by PHP. (But I don't think that logic belongs to Piwik.)

E.g. if the "quick setup/update" can update the site then the black hat also can if there's a security hole in Piwik (or PHP itself).

@anonymous-matomo-user
Copy link

I just read the below message in the updater, and I thought this ticket would be the right place to post it because I cannot see from the commit in comment#2 that it has actually been fixed.

chmod -R 0755 /var/www/piwik

Files are not supposed to be marked executable under no circumstances. If the intention is to make all directories executable, you have to do this:

chmod -R +X /var/www/piwik

Sorry, I'm not a Piwik dev - but I wanted you to know this so your app doesn't spread bad security practices.

Thanks for a great alternative to GA,
Ben

@mattab
Copy link
Member

mattab commented Feb 6, 2014

Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.

@oerdnj oerdnj added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ystem check since it's not required (and we display warning on other screens that need config writable)

Also fixing install process regression and removing config.ini.sample.php
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab
Copy link
Member

mattab commented Mar 18, 2019

see #13628

@mattab mattab closed this as completed Mar 18, 2019
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants