Password validation extension #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion! In this case, i think it is over-engineered to add logic of password validators in core. Why generalise password validators, when we have only one in core? The goal of course is to let plugins add more validators. But In this case, IMHO it is enough to add a new event called 'UsersManager.checkPassword' in this method. Then any plugin could throw an exception when password is not valid. (and plugins can decide for themselves to implement password validators). |
| @@ -444,7 +447,7 @@ public function updateUser($userLogin, $password = false, $email = false, $alias | |||
| * | |||
| * @param string $userLogin The user's login handle. | |||
| */ | |||
| Piwik::postEvent('UsersManager.updateUser.end', array($userLogin)); | |||
| Piwik::postEvent('UsersManager.updateUser.end', array($userLogin, $passwordHasBeenUpdated)); | |||
There was a problem hiding this comment.
add $passwordHasBeenUpdated flag to the Event comment just above, so it shows up in the auto generated doc: http://developer.piwik.org/api-reference/events
…mplement in hook result. (in separate plugins) Added events documentation.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended password validation based on hooks and PasswordValidator interface.