Fix tracking actions with empty page titles using MySQL 5.6+. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added a commit
that referenced
this pull request
May 18, 2014
…aused by the now-enabled-by-default STRICT_TRANS_TABLES setting. To prevent such issues let's run all tests against it. Refs #279 Reused Mysql 5.6 gist provided in travis-ci/travis-ci#1986
mattab
added a commit
that referenced
this pull request
May 18, 2014
|
after enabling strict_mode, the bug is reproducible on travis https://travis-ci.org/piwik/piwik/jobs/25438055 |
mattab
pushed a commit
that referenced
this pull request
May 18, 2014
Fix tracking actions with empty page titles using MySQL 5.6+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error while tracking actions with empty page title using mysql 5.6 default config (STRICT_TRANS_TABLES) as it won't cast false to 0.