Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #4985 Improve Dashboard / Datatables UI #260

Merged
merged 2 commits into from Apr 14, 2014
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 14, 2014

Each dashboard widget shows footer icons, pager, ... but they are usually rarely used. Especially since we store changes in the database and apply them when opening the dashboard again. Therefore we want to hide the widget footer by default but give users the possibility to "expand" the footer. Some reports that provide further controls should be able to add controls to this by default hidden footer to hide complexity. It's up to each report to define useful default values.

Also made the dataTable and All Websites Dashboard look nicer. For instance removed some borders.

refs #4985 Improve Dashboard / Datatables UI

various UI fixes and cleaner datatables

some more ui tweaks

this should make sure to related report text is centered when not displayed within dashboard

darker arrow icon

if there are no footer icons, do nothing

some fixes for the ui improvments, especially annotations related

there should be still a gap when not displayed in dashboard

save the expanded footer state to make sure users who often use the footer do not have to open it each time and also makes sure the footer will be still expanded after reloading the widget etc

move related report closer to the actual report

make sure all annotation pins are in one line and positioned correct

fix issues when dashboard widget is maximised. Annotations were not positioned correct and drawer was displayed

when there is no data or no paging, do not display paging or search

display all websites dashboard similar to other reports

do not display column documentation in dashboard but in other reports

show title on drawer hover

hide related reports if there are no related reports, makes the footer looks better when widgetized

make sure the annotations are positioned correct if opened within a widgetized report transition

a fix for firefox and make sure annotation pins do not jump in dashboard area when loading message is displayed

only on firefox and only within the first two columns the arrow was not displayed fully although the css of the image and parent nodes is the same. this workaround makes sure the arrow of the drawer is always fully visible on firefox

move annotations 6px to the left to be displayed as before
… the annotation pins to prevent a jumping effect
tsteur added a commit that referenced this pull request Apr 14, 2014
refs #4985 Improve Dashboard / Datatables UI
@tsteur tsteur merged commit a02ba00 into master Apr 14, 2014
@tsteur tsteur deleted the cleanerDatatables branch April 14, 2014 05:15
@mattab
Copy link
Member

mattab commented Apr 14, 2014

Guys let us know what you think of this change, it's very visible on the dashboard and is aimed to simplify the interface to let users better focus on their data.

Also helps avoid feature creep 👍

@timo-bes
Copy link
Member

I like it, well done!

Here are a few suggestions:

  • When the footer is closed, the arrow sould point downwards imho, indicating that clicking the arrow will expand the footer.
  • I like how the grey box containing the arrow sits at the bottom of the widget. It works well when it is placed at the border of the widget box. Would it be possible to place the arrow at the bottom of the widget even when the footer is expanded, i.e. below the footer?
  • The click target for showing/hiding the footer is quite narrow. I'd suggest making it as big as possible.

@tsteur
Copy link
Member Author

tsteur commented Apr 14, 2014

good point! Just pushed it. I might add a sliding effect later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants