Ticket 4912 (Users List messup in UsersManager settings UI) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 31, 2014 13:35
…reach, modification integrated also in user's delete button
|
Well, thanks to github, I've easily discovered the contribution that caused regression, I had no clue why doing a foreach using reference, then I've found that PHP "unlinks" references while being in foreach and I suppose this is caused the messup... So this pull request is my solution to 🐛 4912. |
|
Not merging, see: http://dev.piwik.org/trac/ticket/4912 Thanks for the report + research. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing master branch to stable 2.1.0 version, I've discovered a new column in the table id Users called "Last Seen".
Adduser javascript weren't updated so I've integrated an empty cell that would format correctly the "addUser row".
Then I've discovered that foreach row you were using duped IDs for forms inputs. So I've corrected duplications (IDs must be unique), adding the data-target HTML5 attribute.
There stills a problem in the users table: the last row is duped from the previous. Some help is appreciated debugging this mess...
(Ticket Reference: http://dev.piwik.org/trac/ticket/4912)