Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal delete fix #220

Merged
merged 1 commit into from Feb 6, 2014
Merged

Goal delete fix #220

merged 1 commit into from Feb 6, 2014

Conversation

quba
Copy link
Contributor

@quba quba commented Feb 6, 2014

Disallow to delete all conversions for given idgoal (across all websites) after goal (soft)delete.

Disallow to delete all conversions for given idgoal (across all websites) after goal (soft)delete.
@halfdan
Copy link
Member

halfdan commented Feb 6, 2014

@quba Thanks for your PR. Would you mind explaining what error/bug this fixes?

@quba
Copy link
Contributor Author

quba commented Feb 6, 2014

Deleting goal with id 1 for website x deletes all conversions from log_conversions table with idgoal = 1 for ALL idsites.

mattab pushed a commit that referenced this pull request Feb 6, 2014
Thanks for the PR, good find and nice to know this is fixed.
@mattab mattab merged commit efeff67 into matomo-org:master Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants