Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify jqPlot to support retina displays. #169

Merged
merged 1 commit into from Dec 18, 2013
Merged

Modify jqPlot to support retina displays. #169

merged 1 commit into from Dec 18, 2013

Conversation

halfdan
Copy link
Member

@halfdan halfdan commented Dec 17, 2013

fixes #4389

@mattab
Copy link
Member

mattab commented Dec 17, 2013

this sounds cool! is it a code from jqplot itself? will it clash if we later upgrade to latest jqplot? maybe it can be included upstream... Cheers

@halfdan
Copy link
Member Author

halfdan commented Dec 17, 2013

I opened a ticket in trac: http://dev.piwik.org/trac/ticket/4389#comment:1

Basically the issue is that the upstream version hasn't applied this fix yet and there's been no reelase of jqPlot since march. There are three tickets about this currently open: https://bitbucket.org/cleonello/jqplot/issues?q=retina

The code in this PR is basically the fix proposed in one of those tickets. For now I suggest we maintain this ourselves and hope that jqPlot picks up the issue upstream.

tsteur added a commit that referenced this pull request Dec 18, 2013
Modify jqPlot to support retina displays.
@tsteur tsteur merged commit 516dd93 into master Dec 18, 2013
@tsteur
Copy link
Member

tsteur commented Dec 18, 2013

Tried to test it with Chromes new mobile device emulation feature but didn't see a big difference. Maybe it is better visible on an actual retina device? Will merge...

@halfdan halfdan deleted the fix-retina branch December 19, 2013 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants