Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recognition for IE11, Opera 15+ and Maxthon, made Win 8.1 separate entry (#2) #161

Closed
wants to merge 4 commits into from

Conversation

mpopp75
Copy link

@mpopp75 mpopp75 commented Nov 30, 2013

This is an update/replacement for pull request #160

Unit test failures are fixed and commits are squashed to 4 chunks.

Renamed old test script to
UserAgentParser.test.oldbrowsers.php
With abbreviation W81 (instead of WI8)
Add one more entry for Windows 8.1
Add icons for Windows 8.1 and Maxthon
Fix unit test failures
@mattab
Copy link
Member

mattab commented Dec 8, 2013

We plan to use DevicesDetection plugin only going forward. Therefore would you consider instead adding the right detection to the UserAgentParserEnhanced? see: http://dev.piwik.org/trac/ticket/3962#ticket

I prefer not to make changes to UserAgentParser before 2.0 since it could introduce regressions (this code is not well tested unfortunately, but UserAgentParserEnhanced has reasonnable test suite)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants