Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() #13450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hMessage() in controller instead of FrontController in case plugins decide to create their own safemode.
diosmosis
added
the
not-in-changelog
tsteur
reviewed
Sep 19, 2018
| @@ -316,7 +316,9 @@ public function safemode($lastError = array()) | |||
|
|
|||
| $errorMessage = $lastError['message']; | |||
|
|
|||
| if (!empty($lastError['backtrace'])) { | |||
| if (!empty($lastError['backtrace']) | |||
There was a problem hiding this comment.
@diosmosis is it on purpose that this is only done when output format is not HTML? I wonder if it is supposed to be shown on the safemode page when backtrace with message is enabled? I think before it was the case
There was a problem hiding this comment.
AFAIK there was no backtrace to display in the code before (but I never paid that much attention to the safemode html).
There was a problem hiding this comment.
I can display it in the View as well.
|
Added to safemode view:
w/o exception:
Slight change in the second image since the backtrace contains the "in ... line ...". |
|
LGTM if tests pass |
diosmosis
added a commit
that referenced
this pull request
Sep 20, 2018
…hMessage() (#13450) * Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() in controller instead of FrontController in case plugins decide to create their own safemode. * Add backtrace to HTML safemode view too. * Fixing test.
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…hMessage() (matomo-org#13450) * Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() in controller instead of FrontController in case plugins decide to create their own safemode. * Add backtrace to HTML safemode view too. * Fixing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in controller instead of FrontController in case plugins decide to create their own safemode.