Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO plugin Alexa broken #13427

Closed
Findus23 opened this issue Sep 13, 2018 · 0 comments · Fixed by #13552
Closed

SEO plugin Alexa broken #13427

Findus23 opened this issue Sep 13, 2018 · 0 comments · Fixed by #13552
Labels
c: Privacy For issues that impact or improve the privacy. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.

Comments

@Findus23
Copy link
Member

related to #12248

While checking how the SEO plugin works, I noticed that it parses this url:

const URL = 'http://data.alexa.com/data?cli=10&url=';

But it seems like this API doesn't exist anymore (besides the fact that sending the urls via HTTP to other servers isn't a good idea)

http://data.alexa.com/data?cli=10&url=matomo.org
only returns Okay for me and it seems like I am not the only one:
https://stackoverflow.com/questions/3676376/fetching-alexa-data#comment87619041_6224304

@Findus23 Findus23 added c: Privacy For issues that impact or improve the privacy. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 13, 2018
@Findus23 Findus23 added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 2, 2018
diosmosis pushed a commit that referenced this issue Dec 4, 2018
* added fallback method for Alexa, fixes issue #13427

* do not use short array syntax for consistency with other methods

* use mini link for Alexa, use DomXPath to filter out the global ranking instead of regex
sgiehl pushed a commit that referenced this issue Dec 6, 2018
* added fallback method for Alexa, fixes issue #13427

* do not use short array syntax for consistency with other methods

* use mini link for Alexa, use DomXPath to filter out the global ranking instead of regex
diosmosis pushed a commit that referenced this issue Dec 8, 2018
* Add reports dimensions to metadata of report and rows

* translate dimension columns

* updates test files

* fix possible error when no report is available

* update tests

* Improve subdimension detection

* Adjust tests for labelX logic

* Makes flattener compatible with 3 dimensions

* Adds new method getThirdLeveltableDimension to report class

* Do not ask for 2fa authentication code when CoreUpdater is being requested (#13796)

Could fix an edge case where user is logged in, but hasn't confirmed the auth code (so the user is not actually logged in), and then an update appears.

* Added Fallback Method for Alexa in SEO Plugin (#13552)

* added fallback method for Alexa, fixes issue #13427

* do not use short array syntax for consistency with other methods

* use mini link for Alexa, use DomXPath to filter out the global ranking instead of regex

* Use db sessions by default, deprecate file session handler (#13540)

* use db sessions by default, deprecate file session handler

* trying to fix tests

* Prevent trigger errors on demand for instances that are opened to anonymous (#13535)

fix #13513

* Remove the previous exception in base validator so the same error is not printed twice (#13801)

* Fixing build  (#13802)

* update submodule

* Update screenshots and try to get test to pass.

* Get SingleMetricView to pass. (#13803)

* Quickform2 throws warnings with PHP7.2 (#13463)

fixes #13272

Haven't actually tested it but should fix the issue. If tests pass, the logic would be still the same. I don't have a PHP 7.2 running here otherwise at the moment

* Send bulk requests in chunks when needed (#13444)

* send bulk requests in chunks

* send requests correctly

* Make log and report data screen less technical (#13464)

* When you are logged out, the URL gets lost when you log in (#13441)

It won't remember any hash as the hash won't be visible in the referrer etc but it would work for most other pages.

To make it work for hash it would get likely way more complicated like we would need to persist it through JS, temporarily store it somewhere and redirect accordingly. It fixes the case mentioned in the issue.

fix #13328

* show full information of URL only on extra click (#13585)

* Add option to opt in to use send beacon (#13451)

* Add option to opt in to use send beacon

* Fix JS tracker test.

* do not overrwite existing subrow metadata

* update test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Privacy For issues that impact or improve the privacy. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant