Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple test related changes for tests that load multiple other plugins #13319

Merged
merged 5 commits into from Sep 5, 2018
Merged

Couple test related changes for tests that load multiple other plugins #13319

merged 5 commits into from Sep 5, 2018

Conversation

diosmosis
Copy link
Member

Changes:

  • In tests:setup-fixture do not overwrite existing plugins in Fixture::$extraPluginsToLoad.
  • In fixture teardown do not unload plugins if persist fixture data is used, since many plugins will drop database tables in this case. (Allows using this feature w/ plugins like that & allows inspecting these tables after a test.)

@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 20, 2018
@diosmosis diosmosis added this to the 3.7.0 milestone Aug 20, 2018
@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018
@diosmosis
Copy link
Member Author

Fyi @matomo-org/core-team merging this one if build passes

@diosmosis diosmosis merged commit 5e71b34 into 3.x-dev Sep 5, 2018
@diosmosis diosmosis deleted the multi-plugin-system-test branch September 5, 2018 22:51
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Couple test related changes for tests that load multiple other plugins (
1b7326e 
matomo-org#13319)

* In tests:setup-fixture do not overwrite a Fixtures existing extra plugins to load.

* Only uninstall plugins in test if dropDatabaseInTeardown is false.

* Load fixture extra plugins in testing environment manipulator.

* Handle test case fixture too.
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab