Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips appear all over the place but shouldn't #13305

Closed
mattab opened this issue Aug 17, 2018 · 4 comments · Fixed by #13442
Closed

Tooltips appear all over the place but shouldn't #13305

mattab opened this issue Aug 17, 2018 · 4 comments · Fixed by #13442
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Aug 17, 2018

We're now seeing the black tooltip in Matomo over all form fields, and inline helps, etc.

For example:
tooltip

Instead we do not want to see the tooltips on those fields and inline helps etc. Not sure when this was regressed but maybe in some recent Visitor profile/Visitor log improvements?

@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Aug 17, 2018
@mattab mattab added this to the 3.6.0 milestone Aug 17, 2018
@sgiehl
Copy link
Member

sgiehl commented Aug 17, 2018

That's now automatically done for all elements having a title attribute. If no tooltip should be shown we imho should remove the title attribute.

@sgiehl
Copy link
Member

sgiehl commented Aug 17, 2018

Btw. guess that was added in #12800

@mattab mattab modified the milestones: 3.6.0, 3.7.0 Aug 17, 2018
@tsteur
Copy link
Member

tsteur commented Aug 17, 2018

Not sure. Even when a title attribute makes sense, you wouldn't always want to see the tooltip directly. I think there's a reason you usually have to hover something for a while before a tooltip shows up for example. Just because it can be quite annoying to see all the time things popping up and tooltips immediately when you already know what it means etc.

I think it makes sense for some parts that tooltips appear immediately. Such as in the visitor log when hovering the country flag. But often enough the tooltip shouldn't appear immediately.

See eg this screen:
aug-18-2018 09-25-24

I reckon pretty much only the tooltip in the evolution graph on the line makes sense to appear immediately. All other ones should appear only after the regular browser delay.

For some other elements we need to see if we can remove the title attribute 👍 Eg for the form fields. I think the title attribute is used to specify the title/label of the form element and therefore will be always set. So maybe for form elements we can ignore this kind of title attribute automatically everywhere?

Also there are many links with useless tooltips showing up immediately. Eg hover "show visitor profile" link in visitor log. It's rather annoying and there we should remove tooltip as in many other places.

Can we maybe define a class or something to indicate the tooltips that should show up immediately?

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Sep 10, 2018
@mattab
Copy link
Member Author

mattab commented Sep 10, 2018

I reckon pretty much only the tooltip in the evolution graph on the line makes sense to appear immediately. All other ones should appear only after the regular browser delay.

Sounds good that other ones appear after standard browser delay.

So maybe for form elements we can ignore this kind of title attribute automatically everywhere

Makes sense 👍

It's rather annoying and there we should remove tooltip as in many other places.

Not sure if there are many such places, but this one example is definitely to be removed!

@tsteur tsteur self-assigned this Sep 17, 2018
tsteur added a commit that referenced this issue Sep 17, 2018
fix #13305 

Add a delay so tooltips don't appear immediately. Do not show any tooltip for any form field.

In visitor log the titles are still shown immediately but there it is wanted maybe?

I clicked through couple of pages and looked a bit in the code but it is hard to find all the places where a title attribute should be removed. Maybe we do this better over time.
tsteur added a commit that referenced this issue Nov 21, 2018
* Tooltips appear all over the place but shouldn't

fix #13305 

Add a delay so tooltips don't appear immediately. Do not show any tooltip for any form field.

In visitor log the titles are still shown immediately but there it is wanted maybe?

I clicked through couple of pages and looked a bit in the code but it is hard to find all the places where a title attribute should be removed. Maybe we do this better over time.

* Remove tooltip as the link already shows the same text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants