Use request instead of API instance so events are triggered in MultiSites. #13289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
not-in-changelog
…names in filter not queued filter in MultiSites.getAll.
|
Seems your changes changed the API response. API tests now have different results... |
|
Updated. |
|
Still some test changes in Integration tests. But maybe the results are now kind of expected? |
|
Should be fine if tests pass 👍 |
diosmosis
added a commit
that referenced
this pull request
Sep 20, 2018
…ites. (#13289) * Use request instead of API instance so events are triggered in MultiSites. * Add required query params to MultiSites/Dashboard and rewrite column names in filter not queued filter in MultiSites.getAll. * Fix tests. * fixing tests.
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…ites. (matomo-org#13289) * Use request instead of API instance so events are triggered in MultiSites. * Add required query params to MultiSites/Dashboard and rewrite column names in filter not queued filter in MultiSites.getAll. * Fix tests. * fixing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.