Change default opt out text & allow opt out text to be customized across entire install #13277
Conversation
… text & add system settings for default opt out form values.
diosmosis
added
the
Pull Request WIP
diosmosis
added
Needs Review
| </div> | ||
|
|
||
| <h3>Customize opt-out text</h3> | ||
| <div> |
There was a problem hiding this comment.
@diosmosis when I used it, it wasn't clear to me what the "customise opt-out text" does in privacy manager. eg does it append it as URL parameter, is it only for showing it, is it saving it (but there is no save button which we usually always have), etc. I think it be better to remove it from this screen, or only show it disabled as a hint of what the text is. This makes it also easier when there is only one place where it can be edited.
Also only super users should be able to change that but admin users can view this page so for them it wouldn't work.
| protected function init() | ||
| { | ||
| $this->privacyPolicyUrl = $this->createPrivacyPolicyUrlSetting(); | ||
| $this->termsAndConditionUrl = $this->createTermsAndConditionUrlSetting(); | ||
| $this->showInEmbeddedWidgets = $this->createShowInEmbeddedWidgetsSetting(); | ||
| $this->defaultOptedInText = $this->createDefaultOptedInTextSetting(); |
There was a problem hiding this comment.
How does this work for different languages? Currently, we have a feature to specify the language in the URL and we pick the correct language depending on browser setting... in this case would we need to mention it overwrites all languages? @diosmosis
There was a problem hiding this comment.
Didn't know it would be translated by language (or maybe forgot). Maybe this is best solved by the custom translations plugin?
For this feature I suppose we should say it will only be translated if the default text is used, then link to the custom translations plugin.
There was a problem hiding this comment.
Actually, I wonder if this would be solvable by just using the custom translations plugin? w/o the need for a new setting. @tsteur
There was a problem hiding this comment.
In Custom Translations there is no logic yet to translate any core translations / translation keys. Only entities and tracked values (eg dashboard names, custom dimension names, tracked event values, ...). However, https://plugins.matomo.org/CustomiseTranslations should do this and in theory someone could already use that plugin to customise the opt out translation if they wanted. I think I would very very much like if we referred people that want to customise the text to that plugin as I think < 0.2% or so will ever customise it.
There's also https://plugins.matomo.org/CustomOptOut which could potentially implement this maybe.
And for those that use it, they might have even quite custom requirements. Eg they track several websites in one Matomo where some are Intranet, some are ... some are ... and they might end up simply needing to use a custom opt out form or something.
To fix #12810 simply adjusting the opt-out text should do IMO.
|
Removed the extra unneeded feature, went a bridge too far. |
|
@tsteur fyi, removed all unneeded changes from this PR, will merge once build succeeds |
|
sounds good 👍 |
I tried making opt out text customizable by site, but didn't know how to get the idSite in the opt out form. So I scrapped that.
Fixes #12810