Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit by hour should show report based on first action time #13175

Merged
merged 9 commits into from Dec 8, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 17, 2018

Just a suggestion. IMO it is way more important to see at what hour you acquired specific users compared to when they dropped off. Especially if you are running certain ads for example etc. We could also add another report "first" and "last action" hour but I think that not both are actually needed and keeping it simple be better.

Performance wise this shouldn't have really any impact as the index be still used in the back by the where statement.

Could also save it for Matomo 4 or so.

Just a suggestion. IMO it is way more important to see at what hour you acquired specific users compared to when they dropped off. Especially if you are running certain ads for example etc. We could also add another report "first" and "last action" hour but I think that not both are actually needed and keeping it simple be better.

Performance wise this shouldn't have really any impact as the index be still used in the back by the where statement.
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 17, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and imho totally makes sense to calculate that based on the time of first action.

@tsteur
Copy link
Member Author

tsteur commented Jul 24, 2018

@mattab just quickly checking you are ok with this as well?

@mattab
Copy link
Member

mattab commented Jul 25, 2018

It should be fine. The only "problem" could be that, when you sum the visits for this report Visits by server time, then it won't necessarily match the overall visits for the day, because if a visit overlaps two days they will appear for DAY1 in the Visits by server time graph, but won't be included in the DAY1 overall visits metrics. (To process overall visits we use the server time at the end of the visit.)

that said I don't think it's a blocker, but we may get a few questions, it should be fine 👍

@tsteur
Copy link
Member Author

tsteur commented Jul 26, 2018

By default we create a new visit after midnight correct? So it might reduce the problem?

@mattab
Copy link
Member

mattab commented Jul 26, 2018

Good point, forgot about this, was done in #6217, so it's all good

@tsteur
Copy link
Member Author

tsteur commented Jul 28, 2018

Fixed ui tests. Looked at the report description and looks like the report description was already written generic and not that it was based on the last action time. But maybe we should make it a bit more clear on what it is based?

@mattab mattab added this to the 3.7.0 milestone Aug 11, 2018
@diosmosis
Copy link
Member

Noticed the GetVisitInformationPerServerTime report class still uses the VisitLastActionTime dimension. Should this change?

@tsteur
Copy link
Member Author

tsteur commented Dec 6, 2018

Noticed the GetVisitInformationPerServerTime report class still uses the VisitLastActionTime dimension. Should this change?

I'm actually not sure. Might be a good idea. I could change it to first action time dimension and we see what happens re tests. Shouldn't affect too much I suppose. Possibly processed reports may be better.

@tsteur
Copy link
Member Author

tsteur commented Dec 6, 2018

just pushed the change now.

@diosmosis diosmosis merged commit cf7d636 into 3.x-dev Dec 8, 2018
@diosmosis diosmosis deleted the hourfirstactiontime branch December 8, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants