Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config file and configuration overview in admin #13151

Closed
sgiehl opened this issue Jul 9, 2018 · 4 comments
Closed

Improve config file and configuration overview in admin #13151

sgiehl opened this issue Jul 9, 2018 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.

Comments

@sgiehl
Copy link
Member

sgiehl commented Jul 9, 2018

We show an overview over all available and set configurations in Matomo administration.
Therefor the global.ini.php is parsed.
As we have a few config values that are completely commented out by default this view is a bit broken:

image

image

Those lines also include config values that are completely commented out.
Merging matomo-org/component-ini#9 and updating the component might help a bit. But those value entries might be hidden completely afterwards.

Maybe we should provide a default value for ALL config values!?

@matomo-org/core-team anyone any opinion on that?
@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels Jul 9, 2018
@diosmosis
Copy link
Member

Looking at matomo-org/component-ini#9 it might fix it? Or I guess the problem is cors_domains wouldn't display at all then like cors_domains? I wonder if you can set it to an empty array in INI...

@sgiehl
Copy link
Member Author

sgiehl commented Jul 9, 2018

with the component changes, config keys that are commented out wouldn't be displayed at all in most cases (if there are blank lines in between). Imho it would be the best solution to have default values for all config values. But afaik there's no possibility to set an empty array in INI.

@tsteur
Copy link
Member

tsteur commented Jul 9, 2018

with the component changes, config keys that are commented out wouldn't be displayed at all in most cases (if there are blank lines in between)

be good if they could still be displayed

The problem otherwise really is that some settings shouldn't be set by default like the proxy headers or proxy ips maybe and especially instance_id. Also we can never really guarantee that a default value is set...
Just a random thought as there are not too many with no value... can we somehow whitelist them and then parse somehow the comments for eg ; $whitelistedConfig and ;$whitelistedConfig to detect them somehow? Haven't looked into it...

@Findus23
Copy link
Member

In the meantime thanks to matomo-org/component-ini#9 the comments are quite readable, but commented out options are still missing. (but to be fair, I think they would confuse more than help)

grafik

@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @sgiehl @Findus23