Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying to detect if a period is already running, include the actual period #13149

Merged
merged 1 commit into from Jul 9, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 9, 2018

This change is not 100% needed I think because we also always check if ($cliMulti->isCommandAlreadyRunning($url)) { which should detect if the current period is running. However, we still sometimes see the same archive process is running multiple times and maybe that fixes it.

…ual period

This change is not 100% needed I think because we also always check `if ($cliMulti->isCommandAlreadyRunning($url)) {`  which should detect if the current period is running. However, we still sometimes see the same archive process is running multiple times and maybe that fixes it.
@tsteur tsteur changed the title When trying to detect if a period is already running, include the act… When trying to detect if a period is already running, include the actual period Jul 9, 2018
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 9, 2018
@tsteur tsteur added this to the 3.6.0 milestone Jul 9, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@tsteur tsteur merged commit a4c01fe into 3.x-dev Jul 9, 2018
@tsteur tsteur deleted the lowerorsamearchiveperiod branch July 9, 2018 19:48
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…ual period (matomo-org#13149)

This change is not 100% needed I think because we also always check `if ($cliMulti->isCommandAlreadyRunning($url)) {`  which should detect if the current period is running. However, we still sometimes see the same archive process is running multiple times and maybe that fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants