Improve the style of the glossary #13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
the
c: Design / UI
There is a glossary? |
|
That's what I mean 😄 You can find it at https://glossary.matomo.org/ or at |
|
I think so far we inlined quite a few styles as the styles were initially not loaded on glossary.matomo.org but that has been changed now. Ideally there would be like a glossary.less but that place should be fine as well. |
|
@Findus23 fyi moved it into a separate file. If the UI tests pass it will be good to merge. |
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* fix glossary table of content style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the style of the glossary.
Also made line blue so it fits the tabs above.
Is this the right file to add the CSS?
PS: I think the glossary is a bit too well hidden (I only found a small link on the help page). Maybe it should be a bit more prominent as I think many Matomo users don't know about it.