Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsanatize emails when checking if valid #13141

Closed
wants to merge 1 commit into from

Conversation

tditto23
Copy link

@tditto23 tditto23 commented Jul 5, 2018

fixes #11796
When checking for valid email, use the common function to unsantize the input to allow for special characters in email addresses

@Findus23 Findus23 changed the title 11796 Unsanatize emails when checking if valid Unsanatize emails when checking if valid Jul 7, 2018
@Findus23 Findus23 added the Needs Review PRs that need a code review label Jul 7, 2018
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually not unsanitize it in the validator but instead in the places where this method is called basically. For example in UsersManager.addUser API to prevent random bugs and security issues. The email won't always be sanitized when it is checked in that method but only in some cases.

@mattab
Copy link
Member

mattab commented Aug 11, 2018

@tditto23 please see Thomas feedback. Closing the PR for now but please re-open if you are able to make the suggested changes 👍

@mattab mattab closed this Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-Mail addresses with special characters are not working
4 participants