Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only attempt to link provider if it's a valid hostname #13120

Merged
merged 1 commit into from Jul 1, 2018

Conversation

richardjohn
Copy link
Contributor

@richardjohn richardjohn commented Jul 1, 2018

Fixes #13045
The problem wasn't as described - any single word provider name was linked, regardless of whether it contained com/net/org.

Changed to only return a URL if the provider name is a valid hostname (using Zend_Validate_Hostname). Also changed the startpage search term to be the pretty name if available.

@Findus23 Findus23 changed the title Fixes #13045 - only attempt to link provider if it's a valid hostname only attempt to link provider if it's a valid hostname Jul 1, 2018
@Findus23 Findus23 added the Needs Review PRs that need a code review label Jul 1, 2018
@sgiehl sgiehl mentioned this pull request Jul 1, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jul 1, 2018
@sgiehl
Copy link
Member

sgiehl commented Jul 1, 2018

@richardjohn Thanks for your PR!

@sgiehl sgiehl merged commit e515c23 into matomo-org:3.x-dev Jul 1, 2018
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants