Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1304 bugfix isp com fix #13110

Closed
wants to merge 9 commits into from
Closed

1304 bugfix isp com fix #13110

wants to merge 9 commits into from

Conversation

sunsplat
Copy link

Fix ISP issue

@sunsplat sunsplat mentioned this pull request Jun 28, 2018
Closed
@Findus23 Findus23 added the Needs Review PRs that need a code review label Jun 28, 2018
@fdellwing
Copy link
Contributor

What exactly will that fix? Now it will link you everytime to startpage.com instead of even trying to check for a valid URL?

@sgiehl
Copy link
Member

sgiehl commented Jul 1, 2018

closing in favor of #13120

@sgiehl sgiehl closed this Jul 1, 2018
@sgiehl sgiehl added the duplicate For issues that already existed in our issue tracker and were reported previously. label Jul 1, 2018
@sunsplat sunsplat deleted the 1304-bugfix-isp-com-fix branch July 6, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sunsplat @fdellwing @sgiehl @Findus23 @mattab @lwille @szepeviktor