Update cacert.pem (used for validating SSL connections) #13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
c: Security
sgiehl
reviewed
Jun 24, 2018
| @@ -1,14 +1,13 @@ | |||
| ## How to update this file | |||
| ## - download latest from https://curl.haxx.se/ca/cacert.pem | |||
| ## - Paste the content below this comment | |||
| ## - Leave in there also the Let's encrypt certificate (the first one in the list) | |||
There was a problem hiding this comment.
Was it on purpose to remove the let's encrypt certificate?
There was a problem hiding this comment.
As far as I know the let's encrypt CA is already trusted by every major CA so there should be no reason to additionally add it.
There was a problem hiding this comment.
If that's the case, it should be good to merge.
There was a problem hiding this comment.
I guess if this breaks anything (which it shouldn't unless something is already broken) is something we will only find out after many users are testing the beta.
There was a problem hiding this comment.
LE is crosssigned by IdenTrust which is trusted by everything (important) newer than windows XP >SP3.
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for validating SSL connections within Matomo.