show ASN org as ORG aswell #13078
Merged
show ASN org as ORG aswell #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess that was only the case for Legacy if ASN database was used as ISP and ORG. The new plugin does not handle that separate anymore as Maxmind merged those data. Don't have a strong opinion here if a ASN should be handled as ISP and/or ORG. |
|
Well most people that use the "Lite" databases did use the ASN database before for both (because there is no other available). The thing with the ASN is, sometimes it is more of an ISP (like in Deutsche Telekom) and sometimes it is more of an ORG as in (TU Kaiserslautern). We could also merge them into one key if you use ASN, but that would be a bigger change, so this should be the easiest way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://forum.matomo.org/t/geoip-2-organizations-not-showing/28843/2
With the legacy GeoIP plugin, both keys where set to the same value. We should not break that with GeoIp2.