Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage strong passwords by indicating when passwords are weak (and when password don't match) #13070

Open
ankush981 opened this issue Jun 18, 2018 · 6 comments
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@ankush981
Copy link

I think it'd be helpful for the admin to have the following dynamic (JS-driven) indicators, just like WordPress:

  • Indicator for weak passwords
  • Indicator for when passwords don't match
@sgiehl sgiehl added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Aug 19, 2018
@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2018

That could also be added in admin when changing the own password or creating new users

@mattab mattab changed the title Better password handling during installation Encourage strong passwords by indicating weak passwords Aug 28, 2018
@mattab mattab added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Aug 28, 2018
@mattab mattab changed the title Encourage strong passwords by indicating weak passwords Encourage strong passwords by indicating when passwords are weak (and when password don't match) Aug 28, 2018
@mattab
Copy link
Member

mattab commented Aug 28, 2018

Thanks for the suggestion, it would be great & valuable to encourage users to create strong passwords.

Maybe we could create+link to a FAQ on Matomo.org explaining that it's important to use password managers, and store the encrypted database on a backed up drive.

Regarding the indicator when password don't match... maybe we could even remove the need to type the password twice, and only have the password field once? As long as people have a valid email address in their profile they can easily reset the password if there was a typo.

See also #19961

@tsteur
Copy link
Member

tsteur commented Aug 31, 2018

You could also include a most popular password list and throw an error if the entered password appears in there

@Findus23
Copy link
Member

I'm moving this to 3.7 as it has a huge security benefit. (move it back, if you have planned it for a later release)
I also like @tsteur's idea of rejecting (or at least warning about) common password.
Maybe this could even be combined with the new have-i-been-pawned api:
https://haveibeenpwned.com/API/v2#PwnedPasswords

@tsteur
Copy link
Member

tsteur commented Mar 11, 2019

Moving it back to the backlog as it currently doesn't have a priority.

@Findus23 Findus23 added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label May 24, 2020
@Findus23
Copy link
Member

I disagree with my old post above. I don't think (anymore) that a password strength indicator has a huge security benefit.
For stopping terrible passwords the plugins in #13666 are enough.

And any indicator is either incorrect or too simplified or ends up replicating Dropbox's zxcvbn which is too huge for frontend. And one can already easily write a plugin that validates submitted plugins with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

6 participants