Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical page export: label wrongly encoded #13059

Closed
tsoas opened this issue Jun 13, 2018 · 4 comments · Fixed by #13932
Closed

Hierarchical page export: label wrongly encoded #13059

tsoas opened this issue Jun 13, 2018 · 4 comments · Fixed by #13932
Assignees
Milestone

Comments

@tsoas
Copy link

tsoas commented Jun 13, 2018

Matomo version: 3.5.0, MySQL version: 10.1.21-MariaDB, PHP version: 7.1.1

Hello, we encoutered a new issue since we updated to Matomo 3.5.0 : when we try to generate a report of a selected page, we get an empty report.
After some investigation, it seems that the parameter “label” is not well decoded in the query.
By default, the query contains : “label=sg%2520%2526gt%253B%2520pages%2520%2526gt%253B%2520%2540%25252Findex.aspx” and it doesn’t work.
If I manually edit the query in the URL with :
“label=sg%20%26gt%3B%20pages%20%26gt%3B%20%40%252Findex.aspx” then it does work. However, I cannot tell all my customers to use this workaround.

It can be reproduced here https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday&updated=1#?idSite=7&period=day&date=yesterday&category=General_Actions&subcategory=General_Pages&popover=

Select a page under a hierarchy (ex: top > /all) and generate a XML report for it, the query will be:
https://demo.matomo.org/index.php?date=2018-05-15,2018-06-13&expanded=1&filter_limit=100&format=XML&format_metrics=1&idSite=7&label=top%2520%2526gt%253B%2520%2540%25252Fall&method=Actions.getPageUrls&module=API&period=day&token_auth=anonymous
And it’s empty.

@fdellwing
Copy link
Contributor

I'm pretty sure, this happens because the URL is somehow encoded twice. If someone can hint me the file there these links are generated, I'll have a look.

@lf23
Copy link

lf23 commented Jun 14, 2018

Exactly the same issue on 3.5.1

@lutzf
Copy link

lutzf commented Oct 10, 2018

The same error appears under 3.6 also.
The last version, in which the URL is not encoded twice, is the version 3.3.1-b4.

@sgiehl sgiehl self-assigned this Jan 5, 2019
@diosmosis diosmosis added this to the 3.9.0 milestone Jan 22, 2019
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants