Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide GeoIP2 server module settings by default #13053

Merged
merged 2 commits into from Jun 12, 2018
Merged

Hide GeoIP2 server module settings by default #13053

merged 2 commits into from Jun 12, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 11, 2018

As most people won't use the server module it makes more sense to hide the settings by default.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 11, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jun 11, 2018
diosmosis
diosmosis approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if @mattab has to approve or not (I think this was discussed before), so just approving.

@mattab mattab self-requested a review June 12, 2018 14:25
@sgiehl sgiehl merged commit d2fe5a4 into 3.x-dev Jun 12, 2018
@sgiehl sgiehl deleted the hidegeoip2settings branch June 12, 2018 17:42
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Hide GeoIP2 server module settings by default (matomo-org#13053)
653eedf 
* Hide GeoIP2 server module settings by default

* upates tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

@mattab mattab mattab approved these changes

Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @mattab