Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not link empty action urls in real time widget #13049

Merged
merged 1 commit into from Jun 10, 2018
Merged

Do not link empty action urls in real time widget #13049

merged 1 commit into from Jun 10, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 10, 2018

When an empty url is tracked, the href attribute is currently empty, and the browser will link to the current url, which might lead to confusion.

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels Jun 10, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jun 10, 2018
@diosmosis diosmosis merged commit 82ec657 into 3.x-dev Jun 10, 2018
@diosmosis diosmosis deleted the noemptylinks branch June 10, 2018 21:28
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Do not link empty action urls in real time widget (matomo-org#13049)
7dcb1ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis