Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder for SiteUrl is displayed incorrectly #13035

Closed
Findus23 opened this issue Jun 5, 2018 · 3 comments · Fixed by #13125
Closed

Placeholder for SiteUrl is displayed incorrectly #13035

Findus23 opened this issue Jun 5, 2018 · 3 comments · Fixed by #13125
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
3.6.0

Comments

@Findus23
Copy link
Member

Findus23 commented Jun 5, 2018

related to #11279

Those are really low-priority nitpicks but good issues for beginners.

When adding a new website, the placeholder is shown in one line instead of two lines.

screenshot_20180605_095225

This is caused by the spaces here:

matomo/plugins/WebsiteMeasurable/Settings/Urls.php

Line 44 in 918ef6f

'placeholder' => "https://siteUrl.com/ https://siteUrl2.com/",

In addition an placeholder URL like https://siteURL.example/ should be shown as the current text is a real URL.
@Findus23 Findus23 added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Design / UI For issues that impact Matomo's user interface or the design overall. Lower priority labels Jun 5, 2018
@fdellwing fdellwing mentioned this issue Jun 5, 2018
Closed
@sunsplat
Copy link

sunsplat commented Jun 7, 2018

I'd like to work on this

@fdellwing
Copy link
Contributor

fdellwing commented Jun 7, 2018 •
edited

@sunsplat There is a PR for this -> #13036

But if you find a solution that is not ignoring the W3C standard it will be preferred.

@Findus23
Copy link
Member Author

Findus23 commented Jun 7, 2018

@sunsplat If you are interested, we have many more Matomo-Beginner-Friendly issues you could try to tackle:
https://github.com/matomo-org/matomo/labels/help%20wanted

@diosmosis diosmosis added this to the 3.6.0 milestone Jun 21, 2018
@sgiehl sgiehl mentioned this issue Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
3.6.0
4 participants
@diosmosis @Findus23 @sunsplat @fdellwing