Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace piwik url with example url when not having a protocol #13034

Merged
merged 1 commit into from Jun 6, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 5, 2018

Eg when a test contains //localhost/... then it will be replaced with //example.com/piwik in the future so there is no difference between travis and local

Eg when a test contains `//localhost/...` then it will be replaced with `//example.com/piwik` in the future so there is no difference between travis and local
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 5, 2018
@tsteur tsteur added this to the 3.6.0 milestone Jun 5, 2018
@diosmosis diosmosis merged commit de942d0 into 3.x-dev Jun 6, 2018
@diosmosis diosmosis deleted the replacematomourl branch June 6, 2018 21:24
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…-org#13034)

Eg when a test contains `//localhost/...` then it will be replaced with `//example.com/piwik` in the future so there is no difference between travis and local
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants