Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some UI tests, including random failure + allow --piwik-domain use in tests:run-ui #13027

Merged
merged 8 commits into from Jun 1, 2018
Merged

Fix some UI tests, including random failure + allow --piwik-domain use in tests:run-ui #13027

merged 8 commits into from Jun 1, 2018

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jun 1, 2018 •
edited by sgiehl

Changes:

  • Fix regression in feedback form, translation key was not updated in twig template.
  • Pass --piwik-domain in tests:run-ui to phantomjs and in phantomjs to tests:setup-fixture.
  • In TestsSetupFixture fix incorrect unlink() call that deleted the link target instead of the link.
  • Prevent random failure in dashboard w/ realtimemap by applying same query params to normal realtime map UI test.

fixes #13026

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 1, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Jun 1, 2018
sgiehl
sgiehl reviewed Jun 1, 2018
View reviewed changes
tests/PHPUnit/Fixtures/UITestFixture.php Outdated
@@ -24,6 +24,8 @@
use Piwik\Plugins\SitesManager\API as SitesManagerAPI;
use Piwik\Plugins\VisitsSummary\API as VisitsSummaryAPI;
use Piwik\Config as PiwikConfig;
use Piwik\SettingsPiwik;
use Piwik\SettingsServer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess those use statements are unneeded

@sgiehl sgiehl merged commit 8971526 into 3.x-dev Jun 1, 2018
@sgiehl sgiehl deleted the ui-tests-domains branch June 1, 2018 18:44
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Fix some UI tests, including random failure + allow --piwik-domain us…
07f8b73 
…e in tests:run-ui (matomo-org#13027)

* Forward --piwik-domain to sub-commands from tests:run-ui.

* temp commit debugging

* Predictable screenshots for realtime map in dashboard.

* Fix translation regression.

* Update UI test case & screenshots.

* Remove it.only

* update screenshot

* removes unused use statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Missing translation key on help page
2 participants
@diosmosis @sgiehl