Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload and sync processed plugin system test build artifacts #12995

Merged
merged 2 commits into from May 28, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 27, 2018

Also needs adjustments in travis-scripts and our build artifacts viewer...

fixes #12968

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels May 27, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone May 27, 2018
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but code looks good.

$tarFile = $tmpDir . $filename;
file_put_contents($tarFile, $tests);

$tar = new Tar($tarFile, 'bz2');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this $tarFile be unlinked?

@diosmosis
Copy link
Member

@sgiehl Can you point out the PRs on travis-scripts/ui-tests-viewer (if any)?

@sgiehl
Copy link
Member Author

sgiehl commented May 27, 2018

@diosmosis diosmosis merged commit 0e4959e into 3.x-dev May 28, 2018
@diosmosis diosmosis deleted the artifactsupload branch May 28, 2018 21:40
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…org#12995)

* upload and sync plugin system tests artifacts

* Update tests/travis submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins system tests build does not upload artifacts correctly
2 participants