Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to format metrics in export overlay #12987

Merged
merged 3 commits into from Jun 10, 2018
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 24, 2018

Also adds the possibility to show the export url and changes the button to a tag.

fixes #12966
fixes #12974

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 24, 2018
@sgiehl sgiehl force-pushed the exportformatmetrics branch 2 times, most recently from acb1f84 to 5b77ff6 Compare May 31, 2018 20:24
@sgiehl sgiehl added this to the 3.6.0 milestone Jun 3, 2018
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 6, 2018
@diosmosis
Copy link
Member

LGTM. The UI tests are failing, specifically the ReportExporting tests. Wasn't able to fix those quickly.

@sgiehl sgiehl force-pushed the exportformatmetrics branch 3 times, most recently from 1b15240 to 233dea2 Compare June 10, 2018 18:44
@sgiehl
Copy link
Member Author

sgiehl commented Jun 10, 2018

@diosmosis UI tests should be fixed now

@diosmosis diosmosis merged commit 592b13f into 3.x-dev Jun 10, 2018
@diosmosis diosmosis deleted the exportformatmetrics branch June 10, 2018 22:09
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Adds option to format metrics in export overlay

* update ui test

* Make it possible to show the export url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
2 participants