Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR Data Subject Tool: Allow finding a user only through visits segment #12976

Closed
tsteur opened this issue May 24, 2018 · 1 comment · Fixed by #13123
Closed

GDPR Data Subject Tool: Allow finding a user only through visits segment #12976

tsteur opened this issue May 24, 2018 · 1 comment · Fixed by #13123
Assignees
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented May 24, 2018

We should only allow and only show segments that are based on the log_visit table.

All other segments should usually not be needed anyway to identify a data subject. And if so, it could be later still done potentially through the visitor log and segmentation. Although I doubt it is needed.

Why? Because this DB query will query over all visits, joining a segment with log_link_visit_action (or other tables) can not only take a really long time to find the data subjects, it could even result in the worst case maybe in temporary tables etc.

I think it would also make the tool slightly easier to use by showing only more relevant segments.

@mattab any chance to have this in 3.6.0?

@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label May 24, 2018
@mattab
Copy link
Member

mattab commented May 24, 2018

👍 Good call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants