Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split websites and socials into different pages #12973

Merged
merged 8 commits into from May 29, 2018
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 24, 2018

I presume quite a few tests will be failing and we need to fix them.

Now we could maybe also select by default the table with all metrics? @mattab ?

@tsteur tsteur added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label May 24, 2018
@tsteur tsteur added this to the 3.6.0 milestone May 24, 2018
@mattab
Copy link
Member

mattab commented May 24, 2018

IMO it is not sufficient to split the menus, rather we also want to track "Social media" completely separate from "Websites". Then it makes sense to split them in the menu. So we would need to do some work to make "Social media" its own "Referrer" category like Campaign / Website / Search / Direct entry. See #11102

@tsteur
Copy link
Member Author

tsteur commented May 24, 2018

Yes totally. It is just a start to prepare certain things ;) It will be valuable to have the split already independently.

@tsteur tsteur added the Needs Review PRs that need a code review label May 25, 2018
diosmosis added a commit to matomo-org/plugin-CustomDimensions that referenced this pull request May 29, 2018
@diosmosis diosmosis merged commit 6e89958 into 3.x-dev May 29, 2018
@diosmosis diosmosis deleted the websitesocials branch May 29, 2018 03:51
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Split websites and socials into different pages

* remove no longer needed key

* fix some tests

* fix tests

* change default visualization for websites when being viewed through the reporting menu

* fix tests

* Update CustomDimensions submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants