Improved glossary and let plugins add items to it #12958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Enhancement
|
Failing UI tests do not seem to be related to this change. |
sgiehl
approved these changes
May 26, 2018
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)* | |||
| ### New APIs | |||
|
|
|||
| * Added new method `Piwik\API\Request::isRootRequestApiRequest()` to detect if the root request is an API request. | |||
| * Added new event `API.addGlossaryItems` which lets you add items to the glossary. | |||
There was a problem hiding this comment.
Needs to be moved to the correct place before merging
|
The glossary looks great 👍 |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Improved glossary and let plugins add items to it * fix posted param * added pushpin feature * show keyword only for metrics * added UI test * update changelog * fix ui tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current glossary is pretty plain and a bit hard to read and does not even have category titles like "Reports" or "Metrics" see https://glossary.matomo.org/
As I needed to generalize the glossary a bit more so plugins can modify the glossary, I tweaked it a bit using Materialize components tabs, scrollspy and pagination.
Might need to update the changelog if we put this into 3.6.0. I presume for 3.5.1 we don't have enough time.