Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sendContentAsDownload method reusable #12952

Merged
merged 1 commit into from May 22, 2018
Merged

Make sendContentAsDownload method reusable #12952

merged 1 commit into from May 22, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 22, 2018

FYI labeled it as "not-in-changelog" as it won't be a public API and is only something internal. Feel free to remove the label.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 22, 2018
@tsteur tsteur added this to the 3.5.1 milestone May 22, 2018
@diosmosis diosmosis merged commit 8ecd0f1 into 3.x-dev May 22, 2018
@diosmosis diosmosis deleted the senddownload branch May 22, 2018 16:53
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
make sendContentAsDownload method reusable (matomo-org#12952)
3ea0059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis