Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no tooltip is shown in opened limit selection #12939

Merged
merged 1 commit into from May 22, 2018
Merged

Ensure no tooltip is shown in opened limit selection #12939

merged 1 commit into from May 22, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 20, 2018

fixes #12937

@sgiehl sgiehl added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 20, 2018
@diosmosis
Copy link
Member

Works the first time, but then the tooltip is removed from the selector. Guess it has to be re-added after the selector is closed?

@diosmosis
Copy link
Member

Just did a quick test on demo.piwik.org, and if the title=... is on the <input/> in the limit selector and not the .limitSelection div, it seems to work well.

@sgiehl
Copy link
Member Author

sgiehl commented May 21, 2018

Updated it accordingly 👍

@diosmosis diosmosis added this to the 3.5.1 milestone May 22, 2018
@diosmosis
Copy link
Member

Looks good 👍

@diosmosis diosmosis merged commit 68d3b58 into 3.x-dev May 22, 2018
@diosmosis diosmosis deleted the limittooltip branch May 22, 2018 02:16
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Ensure no tooltip is shown in open limit selection (matomo-org#12939)
3b86421
@GTVolk GTVolk mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Tooltip for limit selector appears even when limit selector is open
2 participants
@sgiehl @diosmosis